Changes between Version 2 and Version 3 of Ticket #62


Ignore:
Timestamp:
04/05/18 16:46:48 (6 years ago)
Author:
Maciej Komosinski
Comment:

Restored the full list of (fixed earlier) issues, for documentation purposes

Legend:

Unmodified
Added
Removed
Modified

  • Ticket #62 – Description

    v2 v3  
     11. add f4 tests with invalid genotypes (to test problematic parsing, valgrind)
     21. add f1 tests to see if introducing GeneProps did not change the calculation of properties (and detect the 'm' bug!)
     31. implement approximate, fast, very low and constant complexity coloring in f4 (styles) just like it is done in f1
     41. oper_f4.cpp:137 maybe move all modifier definitions to one location
     51. oper_f4.cpp:178 address this TODO
     61. f4_general.cpp:478 address this TODO
     71. "default move control to neuclasshandler" unclear meaning
     81. same: "error: if no previous"
     91. same: "Need to check if exists"
     101. same: {{{//they belong to neurons}}}
     111. same: "tc3 is only to ensure that in the end  of neuron parameter definition"
     121. check: {{{sprintf((char*)buf2.c_str(), "%d", i1);}}} and all other similar use cases
     131. makeNull() never used?
     141. char       count; repetition counter - TODO discuss the CHAR type
     151. f4_general.h from line 160 upwards. Fix English, merge (remove spaces) * (pointer) with variable names or type names when there is no variable name
     161. unify modifier macros between f1 and f4?
     171. still true? {{{#define F4_MODIFIERS_VISUAL "" //not supported in f4}}}
     181. fix  Geno_f4::style, old pieces of code remain and clash with new
     191. still needed?
    120{{{
    2 1) unify modifier macros between f1 and f4?
    3 2) still true? #define F4_MODIFIERS_VISUAL "" //not supported in f4
    4 3) fix  Geno_f4::style, old pieces of code remain and clash with new
    5 4) still needed?
    621        double       state;            ///<state of neuron
    722        double       inertia;          ///<inertia of neuron
    823        double       force;            ///<force of neuron
    924        double       sigmo;            ///<sigmoid of neuron
    10 
    11 5) out of line comment?
    12 // a collection of cells, like Organism, for developmental encoding
    13 
    14 
     25}}}
     261. out of line comment?
     27{{{// a collection of cells, like Organism, for developmental encoding}}}
    1528and another
    16 // convert f4 geno string to tree structure (internal)
    17 
    18 
    19 6) unclear in parens:
     29{{{// convert f4 geno string to tree structure (internal)}}}
     3021. unclear in parentheses:
     31{{{
    2032@return 0 if repair can be performed, -1 otherwise (the repair flag wasn't set in constructor)
    21 
    22 7) int min, int max -> int mn, int mx
    23 
    24 8) @param current parent of the analysed branch of the genotype
    25 there is no "current" arg?
    26 
    27 9) notation everywhere:
     33}}}
     341. int min, int max -> int mn, int mx
     351. {{{@param current parent of the analysed branch of the genotype}}} - there is no "current" arg?
     361. notation everywhere:
     37{{{
    2838double * v -> double *v
    2939const char * parse() -> const char* parse()