Opened 5 years ago

Closed 3 years ago

#54 closed defect (fixed)

ModelGeometry and fF: fix conv_fF and scale<1 and find_hole==-1

Reported by: Maciej Komosinski Owned by: oriona
Priority: major Milestone:
Component: Framsticks core Version:
Keywords: Cc:

Description

  • investigate and understand the find_hole() function in fF
  • discover why it fails for scaled down spheres
  • fix it and/or try to replace it with a sphere sampling algorithm from ModelGeometry?

Change History (1)

comment:1 Changed 3 years ago by Maciej Komosinski

Resolution: fixed
Status: newclosed
Summary: ModelGeometry and fF: fix conv_fF and scale<0 and find_hole==-1ModelGeometry and fF: fix conv_fF and scale<1 and find_hole==-1

Most probably fixed in r667, just in case the LOG_ERROR message will be printed if find_hole() returned less than zero.
Integration with ModelGeometry? postponed until ModelGeometry? becomes perfect and more flexible than it is now.

Note: See TracTickets for help on using tickets.