Changeset 87 for java/main/src/main/java/com/framsticks/params/Param.java

Timestamp:

06/28/13 11:56:03 (11 years ago)

Author:

psniegowski

Message:

HIGHLIGHTS:

• FramsClass? and contained Param are now immutable classes (like String),

which allows to refer to them concurrently without synchronization
(which for example in turn simplifies GUI management)

• also make Path immutable (which was earlier only assumed)
• add global cache for FramsClasses? created solely and automatically

on base of Java classes.

• add global cache for ReflectionAccess?.Backend precomputed proxy

representations basing on given FramsClass?

• above changes greatly improved GUI responsivness during browsing
• furtherly improve Param class hierarchy
• allow to inject actions on state changes into MultiParamLoader?
• add more tests

CHANGELOG:

Add StatusListener? to MultiParamLoader?.

Minor refactorization in MultiParamLoader?.

First step with auto append.

Add SchemaTest?.

Improve Registry.

Clean up in Registry.

Work out Registry.

Use annotations for Param.

Fix ListChange?.

Improve fluent interface of the FramsClassBuilder?.

Done caching of ReflectionAccess?.Backend

Fix hashCode of Pair.

A step on a way to cache ReflectionAccess?.Backend

Make SimpleAbstractAccess?.framsClass a final field.

Add static cache for FramsClasses? based on java.

Only classes created strictly and automatically
based on java classes are using this cache.

Make all Params immutable.

Many improvement to make Param immutable.

Make PrimitiveParam? generic type.

Several changes to make Param immutable.

Make FramsClass? immutable.

Another improvement to Path immutability.

Several improvements to Path.

Improve PathTest?.

Configurarable MutabilityDetector?.

File:

• java/main/src/main/java/com/framsticks/params/Param.java (modified) (5 diffs)

java/main/src/main/java/com/framsticks/params/Param.java

@@ -2 +2 @@
 
 
-import com.framsticks.params.types.DecimalParam;
-import com.framsticks.params.types.StringParam;
+import javax.annotation.concurrent.Immutable;
+
+import com.framsticks.params.annotations.FramsClassAnnotation;
+import com.framsticks.params.annotations.ParamAnnotation;
 
 /**
@@ -14 +16 @@
  * @author Piotr Śniegowski
  */
+@Immutable
+@FramsClassAnnotation(id = "prop", name = "prop")
 public abstract class Param {
 
         /** The parameter id. */
-        protected String id;
+        protected final String id;
 
+        //TODO
         /**
          * The parameter internal id. It's set by a user to use user's own getId in
          * code
          */
-        protected String internalId;
+        protected final String internalId;
 
         /** The parameter name. */
-        protected String name;
+        protected final String name;
 
         /** The help (description) concerning parameter. */
-        protected String help;
+        protected final String help;
 
         /** The number of group, that parameter belongs to. */
-        protected Integer group;
+        protected final Integer group;
 
         /** The getFlags stored as a bit sum. */
-        protected Integer flags;
+        protected final Integer flags;
 
+        //TODO
         /** The variable determining whether the parameter is an extra parameter. */
-        protected Integer extra;
+        protected final Integer extra;
 
-
-        public Param() {
-
+        public Param(ParamBuilder builder) {
+                id = builder.getId();
+                internalId = builder.getInternalId();
+                name = builder.getName();
+                help = builder.getHelp();
+                group = builder.getGroup();
+                flags = builder.getFlags();
+                extra = 0;
         }
 
+        @ParamAnnotation
         public String getId() {
                 return id;
@@ -53 +65 @@
         }
 
+        @ParamAnnotation
         public String getName() {
                 return name;
         }
 
+        @ParamAnnotation
         public String getHelp() {
                 return help;
         }
 
+        @ParamAnnotation
         public Integer getGroup() {
                 return group;
         }
 
+        @ParamAnnotation
         public Integer getFlags() {
                 return flags;
@@ -79 +95 @@
         public Integer getExtra() {
                 return extra;
-        }
-
-        public void setInternalId(String internalId) {
-                this.internalId = internalId;
         }
 
@@ -104 +116 @@
         }
 
-        public static FramsClass getFramsClass() {
-                return new FramsClass("prop", "prop", null)
-                        .append(Param.build().id("name").name("Name").type(StringParam.class).finish())
-                        .append(Param.build().id("id").name("Id").type(StringParam.class).finish())
-                        .append(Param.build().id("type").name("Type").type(StringParam.class).finish())
-                        .append(Param.build().id("help").name("Help").type(StringParam.class).finish())
-                        .append(Param.build().id("flags").name("Flags").type(DecimalParam.class).finish());
-        }
-
         public static ParamBuilder build() {
                 return new ParamBuilder();
         }
 
+        public static ParamBuilder build(FramsClassBuilder builder) {
+                return new ParamBuilder(builder);
+        }
+
 }