Changeset 1056 for cpp/frams/genetics


Ignore:
Timestamp:
12/28/20 02:06:52 (3 years ago)
Author:
Maciej Komosinski
Message:

Cosmetic

Location:
cpp/frams/genetics/fS
Files:
3 edited

Legend:

Unmodified
Added
Removed
  • cpp/frams/genetics/fS/fS_general.cpp

    r1032 r1056  
    1212#include "../genooperators.h"
    1313#include "common/nonstd_math.h"
    14 #include "../../model/geometry/part_distance_estimator.h"
     14#include <frams/model/geometry/part_distance_estimator.h>
    1515
    1616int fS_Genotype::precision = 4;
     
    482482        Pt3D scale;
    483483        calculateScale(scale);
    484         return GeometryUtils::isSolidPartScaleValid(partShape, scale);
     484        return GeometryUtils::isSolidPartScaleValid(partShape, scale, true); //2020-12: mac->JS: I set the last argument to true because this is how the original code worked, but I think it should be ensureCircleSection?
    485485}
    486486
     
    910910        Part *parentTmpPart = PartDistanceEstimator::buildTemporaryPart(parent->partShape, parentScale, parent->getRotation());
    911911
    912         double result;
    913912        tmpPart->p = state->v;
    914         result = PartDistanceEstimator::calculateDistance(*tmpPart, *parentTmpPart, genotypeParams.distanceTolerance, genotypeParams.relativeDensity);
    915 
     913        double result = PartDistanceEstimator::calculateDistance(*tmpPart, *parentTmpPart, genotypeParams.distanceTolerance, genotypeParams.relativeDensity);
    916914
    917915        delete tmpPart;
  • cpp/frams/genetics/fS/fS_oper.cpp

    r1032 r1056  
    339339        {
    340340                geno.getState(false);
    341                 mutateScaleParam(newNode, SCALE_X, true);
     341                mutateScaleParam(newNode, SCALE_X, true); //TODO 2020-12: mac->JS: should be true or rather ensureCircleSection?
    342342                mutateScaleParam(newNode, SCALE_Y, true);
    343343                mutateScaleParam(newNode, SCALE_Z, true);
  • cpp/frams/genetics/fS/fS_oper.h

    r1030 r1056  
    142142
    143143        /**
    144          * Change the value of the scale parameter by given multiplier
    145          * Do not change the value if any of the scale restrictions is not satisfied
     144         * Change the value of the scale parameter by a given multiplier.
     145         * Do not change the value if any of the scale restrictions is not satisfied.
    146146         * @param paramKey
    147147         * @param multiplier
    148148         * @param ensureCircleSection
    149          * @return True if the parameter value was change, false otherwise
     149         * @return True if the parameter value was changed, false otherwise
    150150         */
    151151        bool mutateScaleParam(Node *node, string key, bool ensureCircleSection);
Note: See TracChangeset for help on using the changeset viewer.