Changeset 803 for cpp/frams/genetics/fL/fL_general.h

Timestamp:

06/07/18 17:42:49 (6 years ago)

Author:

Maciej Komosinski

Message:

Performance improvements, including avoiding unnecessary passing of objects by value

File:

• cpp/frams/genetics/fL/fL_general.h (modified) (7 diffs)

cpp/frams/genetics/fL/fL_general.h

@@ -315 +315 @@
          * @return string with trimmed spaces
          */
-        static std::string trimSpaces(std::string data);
+        static std::string trimSpaces(const std::string& data);
 
         /**
@@ -328 +328 @@
          * @return 0 if processing ended successfully, 1-based position of error otherwise
          */
-        int processLine(fLElementType type, SString line, fL_Element *&obj, int linenumber, int begin, int end);
+        int processLine(fLElementType type, const SString &line, fL_Element *&obj, int linenumber, int begin, int end);
 
         /**
@@ -343 +343 @@
          * @return 0 if processing finished successfully, 1-based position of error if it occured
          */
-        int parseGenotype(SString genotype);
+        int parseGenotype(const SString &genotype);
 
         /**
@@ -365 +365 @@
          * @return true if new token is found, false if there is no more tokens or when there was parenthesis mismatch (if pos == -1, then it is parenthesis mismatch)
          */
-        bool getNextObject(int &pos, SString src, SString &token);
+        bool getNextObject(int &pos, const SString &src, SString &token);
 
         /**
@@ -376 +376 @@
          * @return 0 if conversion went successfully, 1 when there is a problem with parsing
          */
-        int createWord(SString worddef, fL_Word *&word, int numparams, int begin, int end);
+        int createWord(const SString &worddef, fL_Word *&word, int numparams, int begin, int end);
 
         /**
@@ -385 +385 @@
          * @return 0 if tokenizing finished successfully, 1 otherwise
          */
-        int tokenize(SString sequence, std::list<fL_Word *> &result, int numparams, int begin, int end);
+        int tokenize(const SString &sequence, std::list<fL_Word *> &result, int numparams, int begin, int end);
 
         /**
@@ -452 +452 @@
          * @return pointer to the input neuron, or NULL if no neuron could be found
          */
-        Neuro *findInputNeuron(std::pair<std::list<fL_Word *>::iterator, Neuro *> currneu, fL_Word *attractor);
+        Neuro* findInputNeuron(std::pair<std::list<fL_Word *>::iterator, Neuro *> currneu, fL_Word *attractor);
 
         /**