Ignore:
Timestamp:
05/29/18 16:51:14 (6 years ago)
Author:
Maciej Komosinski
Message:

Code formatting

File:
1 edited

Legend:

Unmodified
Added
Removed
  • cpp/frams/util/callbacks.cpp

    r286 r793  
    99int MemberCallbackNode::equals(CallbackNode*n)
    1010{
    11 if (n==this) return 1;
    12 MemberCallbackNode *classok=dynamic_cast<MemberCallbackNode*>(n);
    13 if (!classok) return 0;
    14 return ((userdata==classok->userdata)&&(object==classok->object)&&(member==classok->member));
     11        if (n == this) return 1;
     12        MemberCallbackNode *classok = dynamic_cast<MemberCallbackNode*>(n);
     13        if (!classok) return 0;
     14        return ((userdata == classok->userdata) && (object == classok->object) && (member == classok->member));
    1515}
    1616#endif
     
    1818int FunctionCallbackNode::equals(CallbackNode*n)
    1919{
    20 if (n==this) return 1;
    21 FunctionCallbackNode *classok=dynamic_cast<FunctionCallbackNode*>(n);
    22 if (!classok) return 0;
    23 return ((userdata==classok->userdata)&&(fun==classok->fun));
     20        if (n == this) return 1;
     21        FunctionCallbackNode *classok = dynamic_cast<FunctionCallbackNode*>(n);
     22        if (!classok) return 0;
     23        return ((userdata == classok->userdata) && (fun == classok->fun));
    2424}
    2525
    2626int StatrickCallbackNode::equals(CallbackNode*n)
    2727{
    28 if (n==this) return 1;
    29 StatrickCallbackNode *classok=dynamic_cast<StatrickCallbackNode*>(n);
    30 if (!classok) return 0;
    31 return ((object==classok->object)&&(userdata==classok->userdata)&&(fun==classok->fun));
     28        if (n == this) return 1;
     29        StatrickCallbackNode *classok = dynamic_cast<StatrickCallbackNode*>(n);
     30        if (!classok) return 0;
     31        return ((object == classok->object) && (userdata == classok->userdata) && (fun == classok->fun));
    3232}
    3333
     
    3636CallbackNode* Callback::add(CallbackNode*n)
    3737{
    38 SList::operator+=(n);
    39 return n;
     38        SList::operator+=(n);
     39        return n;
    4040}
    4141
    4242void Callback::removeNode(CallbackNode*n)
    4343{
    44 SList::operator-=(n);
    45 delete n;
     44        SList::operator-=(n);
     45        delete n;
    4646}
    4747
    4848void Callback::remove(CallbackNode*node)
    4949{
    50 CallbackNode *n;
    51 //printf("Hint: removing callbacks (former 'DuoList') is more efficient using removeNode(). (refer to 'callbacks.h')\n");
    52 for (int i=0;n=(CallbackNode *)operator()(i);i++)
    53         if (node->equals(n))
     50        CallbackNode *n;
     51        //printf("Hint: removing callbacks (former 'DuoList') is more efficient using removeNode(). (refer to 'callbacks.h')\n");
     52        for (int i = 0; n = (CallbackNode *)operator()(i); i++)
     53                if (node->equals(n))
    5454                {
    5555                SList::operator-=(i);
    5656                delete node;
    57                 if (n!=node) delete n;
     57                if (n != node) delete n;
    5858                return;
    5959                }
    60 delete node; // tu nie wiem czy na pewno...
     60        delete node; // tu nie wiem czy na pewno...
    6161}
    6262
    6363void Callback::action(intptr_t data)
    6464{
    65 if (size()==0) return;
    66 SList copy=*this;
    67 FOREACH(CallbackNode*,n,copy)
    68         n->action(data);
     65        if (size() == 0) return;
     66        SList copy = *this;
     67        FOREACH(CallbackNode*, n, copy)
     68                n->action(data);
    6969}
    7070
    7171Callback::~Callback()
    7272{
    73 CallbackNode *n;
    74 for (int i=size()-1;i>=0;i--)
     73        CallbackNode *n;
     74        for (int i = size() - 1; i >= 0; i--)
    7575        {
    76         n=(CallbackNode *)operator()(i);
    77         delete n;
    78 // todo: zrobic zeby kolejnosc delete callbacknode <-> delete callback nie wplywala na poprawne dzialania
    79 // blad odkryty 24.01 pokazal, ze deletowanie callbacknodow w ~callback
    80 // moze powodowac problemy, jezeli obiekty sa usuwane w "zlej" kolejnosci
    81 // ale na razie tak zostanie
     76                n = (CallbackNode *)operator()(i);
     77                delete n;
     78                // todo: zrobic zeby kolejnosc delete callbacknode <-> delete callback nie wplywala na poprawne dzialania
     79                // blad odkryty 24.01 pokazal, ze deletowanie callbacknodow w ~callback
     80                // moze powodowac problemy, jezeli obiekty sa usuwane w "zlej" kolejnosci
     81                // ale na razie tak zostanie
    8282        }
    8383}
Note: See TracChangeset for help on using the changeset viewer.