Changeset 1299 for cpp/frams/genetics/fH/fH_oper.cpp

Timestamp:

03/29/24 23:34:00 (13 months ago)

Author:

Maciej Komosinski

Message:

More reasonable usage of size_t, int, and unsigned int, and their conversions

File:

• cpp/frams/genetics/fH/fH_oper.cpp (modified) (3 diffs)

cpp/frams/genetics/fH/fH_oper.cpp

@@ -237 +237 @@
 
         // used for computing chg
-        unsigned int sumgenes = creature->sticks.size() + creature->neurons.size() + creature->connections.size();
+        size_t sumgenes = creature->sticks.size() + creature->neurons.size() + creature->connections.size();
 
         // if there is only one element in genotype (stick), then deletion would end
@@ -401 +401 @@
 unsigned int Geno_fH::getRandomHandle(fH_Builder *creature, fH_Handle *&handle, ParamEntry *&tab, bool skipalonestick)
 {
-        unsigned int allhandlescount = creature->connections.size() + creature->neurons.size();
+        size_t allhandlescount = creature->connections.size() + creature->neurons.size();
         if (!skipalonestick || creature->sticks.size() > 1)
         {
                 allhandlescount += creature->sticks.size();
         }
-        unsigned int toselect = rndUint(allhandlescount);
-        if (toselect < creature->connections.size())
+        int toselect = rndUint(allhandlescount);
+        if ((size_t)toselect < creature->connections.size())
         {
                 handle = creature->connections[toselect];
@@ -413 +413 @@
                 return toselect;
         }
-        else if (toselect - creature->connections.size() < creature->neurons.size())
-        {
-                toselect -= creature->connections.size();
+        else if (toselect - (int)creature->connections.size() < (int)creature->neurons.size())
+        {
+                toselect -= (int)creature->connections.size();
                 handle = creature->neurons[toselect];
                 tab = creature->neuronparamtab;
+                if (toselect < 0)
+                        logMessage("Geno_fH", "getRandomHandle", LOG_CRITICAL, "toselect<0");
                 return toselect;
         }
-        toselect -= creature->connections.size() + creature->neurons.size();
+        toselect -= int(creature->connections.size() + creature->neurons.size());
         handle = creature->sticks[toselect];
         tab = creature->stickparamtab;
+        if (toselect < 0)
+                logMessage("Geno_fH", "getRandomHandle", LOG_CRITICAL, "toselect<0");
         return toselect;
 }