Changeset 1229 for cpp/frams/genetics/f4/f4_general.h

Timestamp:

04/30/23 02:11:46 (20 months ago)

Author:

Maciej Komosinski

Message:

• More strict parsing (reporting errors instead of implicit fixes)
• Simplified and optimized parsing of neuron class names
• Added a number of comments on parsing peculiarities

File:

• cpp/frams/genetics/f4/f4_general.h (modified) (2 diffs)

cpp/frams/genetics/f4/f4_general.h

@@ -42 +42 @@
 
 /**
+ * TODO MacKo 2023-04: not sure if this function is needed and if f4_processRecur() would not suffice
+ * if it advanced the string pointer (in/out parameter) while processing. Its returned value is always used after
+ * f4_processRecur() anyway, and in two cases likely incorrectly (for [...] to detect closing ']'
+ * and for :...: to detect closing ':') - we don't need recursion in these cases, a simple linear
+ * scan would suffice, but even this would not be needed - since we are parsing the actual characters in these cases,
+ * we do scanning anyway. So looks like this function doubles the work already done more thoroughly by f4_processRecur().
+ * 
  * Scans f4 genotype string for a stopping character and returns the position of
  * this stopping character or 1 if the end of string was reached. This method is used
@@ -494 +501 @@
  * @return 0 if processing was successful, otherwise returns the position of an error in the genotype
  */
-int f4_processRecur(const char *genot, unsigned pos0, f4_Node *parent);
+int f4_processRecur(const char *genot, unsigned int pos0, f4_Node *parent);
 
 /**